Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add GITHUB_TOKEN in e2e tests to prevent rate limiting when querying GitHub API #252

Merged
merged 1 commit into from
May 9, 2024
Merged

ci: add GITHUB_TOKEN in e2e tests to prevent rate limiting when querying GitHub API #252

merged 1 commit into from
May 9, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented May 9, 2024

What this PR does / why we need it:

Avoid https://github.com/Kong/gateway-operator/actions/runs/9017365379/job/24775726082

    test_helm_install_upgrade.go:47: 
        	Error Trace:	/home/runner/work/gateway-operator/gateway-operator/test/e2e/environment.go:183
        	            				/home/runner/work/gateway-operator/gateway-operator/test/e2e/test_helm_install_upgrade.go:47
        	Error:      	Received unexpected error:
        	            	failed to deploy addon cert-manager: couldn't fetch latest jetstack/cert-manager release: GET https://api.github.com/repos/jetstack/cert-manager/releases/latest: 403 API rate limit exceeded for 4.236.120.25. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 36m19s]
        	Test:       	TestE2E/TestHelmUpgrade

Which issue this PR fixes

Fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek self-assigned this May 9, 2024
@pmalek pmalek requested a review from a team as a code owner May 9, 2024 12:51
@pmalek pmalek enabled auto-merge (squash) May 9, 2024 12:57
@pmalek pmalek merged commit 7bd9d8f into main May 9, 2024
15 checks passed
@pmalek pmalek deleted the github-token-e2e-tests-prevent-ratelimiting branch May 9, 2024 13:02
@pmalek pmalek mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@programmer04 programmer04 programmer04 approved these changes

Assignees

@pmalek pmalek

Labels
area/ci area/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmalek @programmer04